Changeset 11128 in ntrip for trunk/BNC/src/upload/bncuploadcaster.cpp

Timestamp:

Oct 24, 2026, 11:37:52 PM (6 days ago)

Author:

stuerze

Message:

Some fixes from security point of view

File:

• trunk/BNC/src/upload/bncuploadcaster.cpp (modified) (3 diffs)

trunk/BNC/src/upload/bncuploadcaster.cpp

@@ -24 +24 @@
 
 using namespace std;
+
+// Status line of the caster/proxy answer is "HTTP/1.x 200 ..." or "ICY 200 OK"
+////////////////////////////////////////////////////////////////////////////
+static bool statusOk(const QByteArray& ans) {
+  QList<QByteArray> status = ans.left(ans.indexOf("\r\n")).split(' ');
+  return status.size() >= 2 && status[1] == "200" &&
+         (status[0].startsWith("HTTP/") || status[0] == "ICY");
+}
 
 // Constructor
@@ -284 +292 @@
 
       QByteArray ans = _outSocket->readAll();
-      if (ans.indexOf("200") == -1) {
+      if (!statusOk(ans)) {
         int l = ans.indexOf("\r\n", 0);
         emit(newMessage("Proxy: Connection broken for " + _mountpoint.toLatin1() + "@" +
@@ -331 +339 @@
    QByteArray ans = _outSocket->readAll();
 
-  if (ans.indexOf("200") == -1) {
+  if (!statusOk(ans)) {
     delete _outSocket; _outSocket = 0;
     int l = ans.indexOf("\r\n", 0);