Changeset 11124 in ntrip for trunk/BNC/src/bncnetqueryrtp.cpp

Timestamp:

Oct 24, 2026, 10:10:29 PM (2 weeks ago)

Author:

stuerze

Message:

Some fixes regarding memory corruption from stream data, credential exposure,

File:

• trunk/BNC/src/bncnetqueryrtp.cpp (modified) (6 diffs)

trunk/BNC/src/bncnetqueryrtp.cpp

@@ -47 +47 @@
   _status = finished;
   if (_socket) {
-    QByteArray reqStr = "TEARDOWN " + _url.toEncoded() + " RTSP/1.0\r\n"
+    QByteArray reqStr = "TEARDOWN " + _url.toEncoded(QUrl::RemoveUserInfo) + " RTSP/1.0\r\n"
                       + "CSeq: " + QString("%1").arg(++_CSeq).toLatin1() + "\r\n"
                       + "Session: " + _session + "\r\n"
@@ -59 +59 @@
 void bncNetQueryRtp::slotKeepAlive() {
   if (_socket) {
-    QByteArray reqStr = "GET_PARAMETER " + _url.toEncoded() + " RTSP/1.0\r\n"
+    QByteArray reqStr = "GET_PARAMETER " + _url.toEncoded(QUrl::RemoveUserInfo) + " RTSP/1.0\r\n"
                       + "CSeq: " + QString("%1").arg(++_CSeq).toLatin1() + "\r\n"
                       + "Session: " + _session + "\r\n"
@@ -144 +144 @@
 
     QByteArray reqStr;
-    reqStr = "SETUP " + _url.toEncoded() + " RTSP/1.0\r\n"
+    reqStr = "SETUP " + _url.toEncoded(QUrl::RemoveUserInfo) + " RTSP/1.0\r\n"
            + "CSeq: " + QString("%1").arg(++_CSeq).toLatin1() + "\r\n"
            + "Ntrip-Version: Ntrip/2.0\r\n"
@@ -202 +202 @@
           }
 
-          reqStr = "PLAY " + _url.toEncoded() + " RTSP/1.0\r\n"
+          reqStr = "PLAY " + _url.toEncoded(QUrl::RemoveUserInfo) + " RTSP/1.0\r\n"
                  + "CSeq: " + QString("%1").arg(++_CSeq).toLatin1() + "\r\n"
                  + "Session: " + _session + "\r\n"
@@ -216 +216 @@
               while (!line.isEmpty()) {
                 if (line.indexOf("200 OK") != -1) {
-                  emit newMessage(_url.toEncoded().replace(0,1,"")
+                  emit newMessage(_url.toEncoded(QUrl::RemoveUserInfo).replace(0,1,"")
                             + ": UDP connection established", true);
                   slotKeepAlive();
@@ -233 +233 @@
   _socket = 0;
   _status = error;
-  emit newMessage(_url.toEncoded().replace(0,1,"")
+  emit newMessage(_url.toEncoded(QUrl::RemoveUserInfo).replace(0,1,"")
                   + ": NetQuery, waiting for connect", true);
 }